The outfit goes together...I just don't know that it would be good for a theme park. Shorts and tank top are still good ideas...but maybe some jean shorts and a non-white tank. Sometimes parks can get dirty and I don't know about you but I wouldn't want that outfit getting ruined. You'll also be doing a lot of walking so some sort of converse shoe to TOMs like shoe would be needed.
Yeah it's a lovely summery outfit but not too dressy, I think it's perfect. And because it's shorts it means nothing will flash when you're on a ride. Maybe take a cardigan though in case it rains :)